Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for w.org plugins page to match new copy #1114

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

postphotos
Copy link
Contributor

Updated readme to match new copy that more accurately describes Stream.

@postphotos postphotos requested a review from kasparsd June 17, 2020 01:54
readme.txt Outdated
@@ -1,24 +1,26 @@
=== Stream ===
Contributors: lukecarbis, fjarrett, stream, xwp, kasparsd
Contributors: xwp, kasparsd, derekherman, postphotos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be xwp. Not sure who has access to the stream account on wp.org and this list gives everyone write access to SVN. @kasparsd I can either give you the credentials to the xwp account so you can still push new versions of the plugin or keep you on the list but I don't see why I or Leo would be on this list. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Just pushed a change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure who has access to the stream account on wp.org and this list gives everyone write access to SVN

@derekherman This contributors list is only included in the plugin credits and doesn't give SVN access.

contributors

This attribution also makes the plugin show up on user's list of contributions which is nice:

contributions

The SVN access is managed via Committers under the plugin settings:

committers

@postphotos
Copy link
Contributor Author

Hey @derekherman - I've added the list of contributors as @kasparsd suggested and removed the other non-repo-committing folks from the list.

I think this is good to merge now.

Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

We can iterate on the contributor credits as needed so I'm merging this in.

@kasparsd kasparsd added this to the Version 3.5.0 milestone Jul 1, 2020
@kasparsd kasparsd merged commit 357e6c2 into develop Jul 1, 2020
@kasparsd kasparsd deleted the feature/updated-readme branch July 1, 2020 09:19
@kasparsd kasparsd mentioned this pull request Jul 7, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants